Skip to content

Implement CLI command action #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 18, 2018
Merged

Implement CLI command action #25

merged 10 commits into from
Jan 18, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Jan 17, 2018 •
edited by okolesnyk
Loading

Description

Doing the above requires a ton of small changes to fully support it. We need a new MagentoWebDriver function to correspond to it as well.

Fixed Issues

  • MQE-585 Implement CLI command action

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
TEMP COMMIT
898cbce 
For updating remotes.
@KevinBKozan
MQE-585: Implement CLI command action
82a0272 
- implement test action, add to schema and di.
- add command variable to testgenerator
@KevinBKozan
Merge branch 'MQE-585' of https://github.com/magento/magento2-functio…
b5c41a4 
…nal-testing-framework into MQE-585
@KevinBKozan
Merge branch 'sprint-develop' into MQE-585
52ffadb
@KevinBKozan
MQE-585: Implement CLI command action
57df3f8 
- cli envs are not stored in webdriver config and used there. Also sanitized via the existing util
- custom method renamed for test cleanliness. action is still magnetoCLI, but mapping happens at TestGenerator level.
- Verification test changes.
@KevinBKozan
MQE-585: Implement CLI command action
d839bf8 
- CR fixes.
@KevinBKozan
Merge branch 'develop' into MQE-585
dfb9c3e
@KevinBKozan
MQE-585: Implement CLI command action
5c89842 
- CR fixes.
@KevinBKozan
MQE-585: Implement CLI command action
0c42c5c 
- more CR fixes
@KevinBKozan
Merge branch 'develop' into MQE-585
1104332
@okolesnyk
Copy link
Member

okolesnyk commented Jan 17, 2018 •
edited
Loading

  1. Please update your Pull Request description according our template
  2. Remove TEMP COMMIT 898cbce

@KevinBKozan
Copy link
Contributor Author

@okolesnyk

  1. How should the PR description be changed?
  2. I was going to Squash and Merge, effectively getting rid of the TEMP COMMIT

@okolesnyk
Copy link
Member

  1. Based in this template https://raw.githubusercontent.com/magento/magento2-functional-testing-framework/develop/.github/PULL_REQUEST_TEMPLATE.md
  2. Sounds good.

@KevinBKozan
Copy link
Contributor Author

KevinBKozan commented Jan 17, 2018 •
edited
Loading

@okolesnyk
PR Description updated. Let me know if it's lacking in any way.

EDIT: I am going to wait to merge this until we have delivered changes to 2.3-develop in CE repo. This story had requirements there, and I'd rather not throw a wrench into the huge merge by doing it there before.

@okolesnyk okolesnyk changed the title MQE-585: Implement CLI command action Implement CLI command action Jan 17, 2018
@KevinBKozan KevinBKozan merged commit 8997ba3 into develop Jan 18, 2018
@KevinBKozan KevinBKozan deleted the MQE-585 branch January 18, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @okolesnyk